bugfix: Support repeated source columns in match_values() #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecio
force-pushed
the
aecio/fix_match_values
branch
from
fe7eeff
to
7349080
Compare
This commit fixes an edge case that breaks the match_values() function when the input contains repeated source columns. Previously, the matches were computed for only one of the repeated mappings. This fix allows the output of top_matches(), which contains repeated source values, to be passed as a parameter of the match_values() function.
aecio
force-pushed
the
aecio/fix_match_values
branch
from
7349080
to
a0f8eb9
Compare
|
Just fixed conflicts with PR #75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case that breaks the match_values() function when the input contains repeated source columns. Previously, the matches were computed for only one of the repeated mappings. This fix allows the output of top_matches(), which contains repeated source values, to be passed as a parameter of the match_values() function.