added tests

src/tests/checkers/php_aliases_test.go

@@ -0,0 +1,43 @@
+package checkers
+
+import (
+	"testing"
+
+	"github.com/VKCOM/noverify/src/linttest"
+)
+
+func TestPhpAliases(t *testing.T) {
+	test := linttest.NewSuite(t)
+	test.AddFile(`<?php
+declare(strict_types = "1")
+$_ = join("", []);
+`)
+	test.Expect = []string{
+		`Call to undefined function join`,
+		`Use implode instead of 'join'`,
+	}
+	test.RunAndMatch()
+}
+
+func TestPhpAliasesFunctionCall(t *testing.T) {
+	test := linttest.NewSuite(t)
+	test.AddFile(`<?php
+declare(strict_types = "1")
+$_ = join("", []);
+
+function test($d){
+ocicollmax();
+}
+
+test(join("", []));
+`)
+	test.Expect = []string{
+		`Use OCICollection::max instead of 'ocicollmax'`,
+		`Call to undefined function ocicollmax`,
+		`Use implode instead of 'join'`,
+		`Call to undefined function join`,
+		`Use implode instead of 'join'`,
+		`Call to undefined function join`,
+	}
+	test.RunAndMatch()
+}

src/tests/golden/testdata/quickfix/phpAliases.php

@@ -0,0 +1,9 @@
+<?php
+declare(strict_types = "1")
+$_ = join("", []);
+
+function test($d){
+ocicollmax();
+}
+
+test(join("", []));

src/tests/golden/testdata/quickfix/phpAliases.php.fix

@@ -0,0 +1,9 @@
+<?php
+declare(strict_types = "1")
+$_ = implode("", []);
+
+function test($d){
+OCICollection::max();
+}
+
+test(implode("", []));

src/tests/golden/testdata/quickfix/phpAliases.php.fix.expected

@@ -0,0 +1,9 @@
+<?php
+declare(strict_types = "1")
+$_ = implode("", []);
+
+function test($d){
+OCICollection::max();
+}
+
+test(implode("", []));