整理: CoreAdapter.speakers 出力をモデル化
#1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Hiroshiba
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要:
CoreAdapter.speakers出力をlist[CoreSpeaker]モデル化してリファクタリングCoreAdapterの文字列出力が問題視されており、これはlist[CoreSpeaker]でモデル化できる。また VVAPI とコアを分離する観点では、VVAPI models とは分離されている
CoreSpeakerに基づくモデル化が望ましい。このような背景から、
CoreAdapter.speakers出力をlist[CoreSpeaker]モデル化しCoreSpeakerの定義箇所を移動するリファクタリングを提案します。関連 Issue
ref #1224 (review)
ref #1249