追加: SkipJsonSchemaが要らないモデルの値からSkipJsonSchemaを省いていく #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
SkipJsonSchemaが要らないモデルの値からSkipJsonSchemaを省いていきます。これによってはサードパーティ側のバグになりえる型が出なくなるはず。
例えば
int | SkipJsonSchema[None] = default(None)の場合、という意味になるのですが、実際に入る値は
だったので、返ってくるモデルの値に
キーがあって値がNoneが入ってることがわからないようになってました。これを
int | None = default(None)にすることで、実際の値と型をあわせました。関連 Issue
close #1458
その他
ちなみに
SkipJsonSchemaを付けていたのはpydantic v1→v2アプデのときにモデルの型を一応変えないようにしたため。詳細は