Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 arch on darwin for M1 #35

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Add arm64 arch on darwin for M1 #35

merged 4 commits into from
Aug 16, 2021

Conversation

bencefr
Copy link

@bencefr bencefr commented Jul 19, 2021

This PR allows using the module in a vscode extension on an M1 mac.

@bencefr
Copy link
Author

bencefr commented Jul 20, 2021

@robotdad , @adiazulay , I see you are authors of previous mods to this repo, I'd like to kindly ask you to review this PR.

@adiazulay adiazulay changed the base branch from master to 0.0.21 August 16, 2021 18:12
Copy link
Collaborator

@adiazulay adiazulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'll get it in the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants