reuse ssh terminal when configured #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zikalino
reviewed
Jun 11, 2018
src/sshRunner.ts
Outdated
|
|
||
| constructor(outputChannel: vscode.OutputChannel) { | ||
| super(outputChannel); | ||
|
|
||
| this.folderSyncer = new FolderSyncer(outputChannel); | ||
|
|
||
| vscode.window.onDidCloseTerminal((terminal) => { | ||
|
|
||
| var termianlNames = Object.keys(this.terminalList); |
zikalino
reviewed
Jun 11, 2018
| if (terminal) { | ||
| terminal.show(); | ||
|
|
||
| cmds.push('ansible-playbook ' + targetPlaybook); |
There was a problem hiding this comment.
How will this work with other PR which introduced ansible-playbook params?
There was a problem hiding this comment.
merge. so pls review them, then i can do merge
zikalino
reviewed
Jun 11, 2018
|
|
||
| private sendCommandsToTerminal(terminal: vscode.Terminal, cmds: string[]): void { | ||
| if (utilities.isTelemetryEnabled()) { | ||
| terminal.sendText('export ' + Constants.UserAgentName + '=' + utilities.getUserAgent()); |
There was a problem hiding this comment.
so this will be sent to terminal even if terminal is reused and these variables are already set?
There was a problem hiding this comment.
actually i think there should be if (telemetry) sendCommands... (telemetry commands) when terminal is created.
There was a problem hiding this comment.
those variables may change.
zikalino
suggested changes
Jun 11, 2018
|
telemetry configuration may change. that's why it's sent everytime. actually changed envs are one of concern that I hesitate to add reuse terminal, as we discussed before. |
zikalino
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #119 #73 . Support reuse ssh terminal per configuraiton.
Issue Type