Updated with 32-bit support #31
Conversation
Note: I'm inexperienced in Travis YAML, so feel free to give suggestions
There was a problem hiding this comment.
https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites says:
If you are on Windows or Linux 64 bit systems and would like to compile to 32 bits, you'll need to set the npm_config_arch environment variable to ia32 before running yarn
So I don't think this will work as is. After making that change, would you be able to test that the produced binaries work before we merge?
|
Sure. |
|
What are the build dependencies? What is this |
|
It's a separate binary packaged with $ npx <command>
|
|
OK. Thanks. This might be a good package for chromebrew. |
|
That would be nice-- it is supported in homebrew already |
|
What system do you build on? I'm having trouble. |
|
I build the Darwin version on my local Mac and I build the Linux version in a Docker container. But then ultimately I push changes up and watch how Travis handles it. |
|
Chromebrew doesn't have Docker yet, so I'll see how this will work on my Chromebook. |
|
It's hung at |
|
@JL2210 mind if I take a stab at it? I don't really have a way of testing the binaries -- maybe if I can get them to build you could try running them? |
|
I got the build working after a lot of jumping through hoops -- can you confirm the resulting builds are ok at https://github.com/stripedpajamas/vscodium/releases ? I don't suspect any issues because the builds succeeded without errors. If it looks good I'll put in a PR |
|
See #32 for big code changes that make the builds work. I think this PR can be closed. |
|
Let me double check. |
Fixes #6
Note: I'm inexperienced in Travis YAML, so feel free to give suggestions!