Feature/dashboard redesign #104
Conversation
tonmoy18
force-pushed
the
feature/dashboard-redesign
branch
from
aef82f8
to
abae491
Compare
| @publishables = [] | ||
| # there is almost certainly a better way to do this!!! | ||
| Collection.find(depositor: current_user.user_key).each do |collection| | ||
| unless DoiRequest.find_by_asset_id(collection.id) |
There was a problem hiding this comment.
check if it has identifier
|
|
tonmoy18
force-pushed
the
feature/dashboard-redesign
branch
4 times, most recently
from
bc0f4eb
to
3cef17d
Compare
|
@rotated8 Fixed all the issues brought up during the meeting. Now admins can view all files they have view access to, and normal users can only view their own files (not even files shared with them - this is current behavior). Also had to make the specs pending, I will need time to figure out why they are acting strange. I will create a different pull request with the fixed specs. |
|
Please add the specs to this PR. This is where they're relevant. |
tonmoy18
force-pushed
the
feature/dashboard-redesign
branch
from
a2f71f8
to
5da936c
Compare
|
@rotated8 you are right. I fixed the specs, they should be working now. I just realized I need to add the pagination for files (at least for admin users). I will do that by tonight |
|
@rotated8 Pagination of the add-files page is going to be a non-trivial task. Because currently all the checked files are sent as an array, files that are not in the page won't be sent and be removed from the array. I could use a jquery pagination, but that will still download all the files and use JS to do pagination |
- Add Dashboard icons - Add Publishable view and controller - Implemented draft for dashboard breadcrumb - Remove collections from my facets - Add add files action link for collections list - Fix specs to match new dashboard design - Make dashboard tab groupping centralized in a new helper - Add spec for publishables controller - Add spec for new views - Fix spec for admin users add file
rotated8
force-pushed
the
feature/dashboard-redesign
branch
from
da7b544
to
7595acc
Compare
No description provided.