Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): change how we import React #523

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

ValentinH
Copy link
Owner

@ValentinH ValentinH commented Mar 25, 2024

This should fix #522.

At first, I didn't understand what was going on and then I compared with a random lib like react-range and that was the only difference in the TS definitions. After changing it, it fixed the TS error 🤔

📦 Published PR as canary version: 5.0.6--canary.523.29dc8c6.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link

codesandbox-ci bot commented Mar 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ValentinH ValentinH added bug Something isn't working patch Increment the patch version when merged labels Mar 25, 2024
@ValentinH ValentinH merged commit 3a54b2a into main Mar 25, 2024
5 checks passed
@ValentinH ValentinH deleted the fix-react-import branch March 25, 2024 10:48
Copy link

🚀 PR was released in v5.0.6 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX element class does not support attributes because it does not have a 'props' property.
1 participant