Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.0 support #137

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Rails 7.0 support #137

merged 11 commits into from
Jun 11, 2024

Conversation

taylorrf
Copy link
Contributor

@taylorrf taylorrf commented Jun 7, 2024

Adds support to Rails 7.0 using Ruby 3.1, 3.2 and 3.3

@taylorrf taylorrf self-assigned this Jun 7, 2024
@taylorrf taylorrf marked this pull request as ready for review June 7, 2024 22:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.01961% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (d9d5cbf) to head (d513432).

Files Patch % Lines
...odels/isolated/user_frequent_changes_bad_config.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   97.51%   97.63%   +0.12%     
==========================================
  Files          50       75      +25     
  Lines        1125     1226     +101     
==========================================
+ Hits         1097     1197     +100     
- Misses         28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taylorrf taylorrf changed the title Rails 7 0 support Rails 7.0 support Jun 7, 2024
Copy link
Collaborator

@geeksam geeksam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I've been meaning to add Rails 7 support for a while, but obviously hadn't. :) I've got a PR (#139) that refactors the CircleCI config file considerably; you can either merge that PR into this branch and then merge this one, OR merge this and I'll rebase the other branch.

@taylorrf taylorrf merged commit e79773b into master Jun 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants