refactor: consistent migration tests organization (apache#19635)

ValtechMobility · Jun 9, 2022 · 7eb1bd9 · 7eb1bd9
1 parent 1813e71
commit 7eb1bd9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/...on_tests/migrations/f1410ed7ec95_tests.py → ...te_native_filters_to_new_schema__tests.py b/...on_tests/migrations/f1410ed7ec95_tests.py → ...te_native_filters_to_new_schema__tests.py
diff --git a/tests/integration_tests/migration_tests.py → ...ons/fb13d49b72f9_better_filters__tests.py b/tests/integration_tests/migration_tests.py → ...ons/fb13d49b72f9_better_filters__tests.py
@@ -21,20 +21,17 @@
     upgrade_slice,
 )
 
-from .base_tests import SupersetTestCase
 
+def test_upgrade_slice():
+    slc = Slice(
+        slice_name="FOO",
+        viz_type="filter_box",
+        params=json.dumps(dict(metric="foo", groupby=["bar"])),
+    )
+    upgrade_slice(slc)
+    params = json.loads(slc.params)
+    assert "metric" not in params
+    assert "filter_configs" in params
 
-class TestMigration(SupersetTestCase):
-    def test_upgrade_slice(self):
-        slc = Slice(
-            slice_name="FOO",
-            viz_type="filter_box",
-            params=json.dumps(dict(metric="foo", groupby=["bar"])),
-        )
-        upgrade_slice(slc)
-        params = json.loads(slc.params)
-        self.assertNotIn("metric", params)
-        self.assertIn("filter_configs", params)
-
-        cfg = params["filter_configs"][0]
-        self.assertEqual(cfg.get("metric"), "foo")
+    cfg = params["filter_configs"][0]
+    assert cfg.get("metric") == "foo"
diff --git a/...on_tests/migrations/fc3a3a8ff221_tests.py → ...grate_filter_sets_to_new_format__tests.py b/...on_tests/migrations/fc3a3a8ff221_tests.py → ...grate_filter_sets_to_new_format__tests.py