Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ValveSoftware/Proton/#4269 #4409

Open
wants to merge 1 commit into
base: proton_5.13
Choose a base branch
from

Conversation

gitaen
Copy link

@gitaen gitaen commented Nov 21, 2020

symlinks copied to pfx directory were using wrong relative paths

     ./pfx/drive_c/windows/syswow64/kernel32.dll -> dist/lib/wine/fakedlls/kernel32.dll

fixed to use absolute path

symlinks copied to pfx directory were using wrong relative paths

         ./pfx/drive_c/windows/syswow64/kernel32.dll -> dist/lib/wine/fakedlls/kernel32.dll

fixed to use absolute path
@aeikum
Copy link
Collaborator

aeikum commented Nov 23, 2020

Hmm. I'm not necessarily opposed to this, but I think it shouldn't be necessary. The src argument to that function should be a full path, since Steam launches Proton with a full path. How are you launching Proton so it gets in this state?

@gitaen
Copy link
Author

gitaen commented Nov 24, 2020

I am launching it with
STEAM_COMPAT_DATA_PATH=/tmp/proton_data ./proton run binary.exe

@F1xteR
Copy link

F1xteR commented Dec 25, 2020

Even with the fix applied Proton 5.13-4 still won't launch, same error code.
Did i do something wrong? i applied the fix in the Proton python file and deleted pfx, pycache and dist folders.
I also launched it like above just setting STEAM_COMPAT_DATA_PATH to steamapps/common/Proton 5.13

@ghost
Copy link

ghost commented Dec 28, 2020

@F1xteR STEAM_COMPAT_DATA_PATH should be set to the directory where your pfx wineprefix will be. I set it to $HOME/proton

@opl-
Copy link

opl- commented Jan 9, 2021

In order for this fix to work, you will need to create a new compatdata directory (wine prefix) for the game that's crashing. This is because the issue exists within the code that initializes it which won't run if one already exists.

Step by step instructions (for Steam users):

  1. Apply this patch (for example by manually editing the SteamLibrary/steamapps/common/Proton 5.13/proton file to apply the change).
  2. Find out the app ID of the crashing game through SteamDB or (in Steam beta versions) by right clicking it in the Steam library, opening the Properties window and looking in the bottom left corner.
  3. Go to SteamLibrary/steamapps/compatdata/, rename the directory named after the app ID from step 2 and create a new, empty directory in its place.
    • This directory might contain your saves or other user data. It includes directories such as App Data and Documents. Make sure to backup any important files before deleting it.
  4. Run the game from your Steam library. The empty directory should now contain a fresh wine prefix.
  5. If needed, copy any saves or other user data you need from the old, renamed directory into the new compatdata directory and verify that it worked. After that the old, renamed directory can be deleted.

@nyabinary
Copy link

Why did this never get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants