feat: Update composer dependencies, add php-cs-fixer, phpstan with config #208
Conversation
ptrcksc
commented
Aug 16, 2024
•
ptrcksc
commented
- Update composer dependencies to php 8.1 max.
- Add php-cs-fixer config.
- Add phpstan config.
- Format code.
- Create phpstan baseline, fix one broken return type.
- Refactor wp.php into seperate classes.
- Add typehints to properties in src/Blocks/
- Format readme into new style.
- Upgrade demo app to laravel 10 (php8.1 support).
- Add image upload example to demo app.
- add eslint config.
- format js code.
ptrcksc
force-pushed
the
lifecycle-to-php82
branch
from
4eb3a22
to
1cf0a4b
Compare
README.md
Outdated
|
|
||
| ## Quick start | ||
|
|
||
| ### Installation | ||
|
|
||
| Install package using composer: |
There was a problem hiding this comment.
And would it be good to mention the minimum requirements?
There was a problem hiding this comment.
And would it be good to mention the minimum requirements?
I do not think so, the PHP requirement is set in the composer file: "php": "^8.1",
There was a problem hiding this comment.
That's handy, but people first land on the readme, so if they want to know if their environment can work with this package they would need to check the Composer file, which requires extra clicks.
README.md
Outdated
| <a href="https://van-ons.nl"> | ||
| <img src="https://van-ons.nl/assets/mail/logo-vo-groen-2019-mail.png"/> | ||
| </a> | ||
| <br><br><br> |
There was a problem hiding this comment.
This can go, as it's replaced with the one at the end.
| * @since 5.0.0 | ||
| * @var int | ||
| */ | ||
| public $token_start; |
There was a problem hiding this comment.
I think this should be camelCase, right?
There was a problem hiding this comment.
The constructor parameters should also be camel case.
