feat: Consider XDG_DATA_DIRS while searching for plugins #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core.LoadPlugin() function has been refactored to consider XDG_DATA_DIRS (from the FDO basedir spec) instead of having hardcoded paths. By doing so, there is no need to put "plugins.in" through sed anymore. Also, for this reason, the file has been renamed to "plugins.go" and has been removed from .gitignore and Makefile.
axtloss
reviewed
Oct 21, 2024
This commit reverts changes done to Makefile and core/plugins.in, and corrects some explanation comments accordingly.
axtloss
reviewed
Oct 22, 2024
Comment on lines
+28
to
+29
| globalPluginPathsEnv, isGPPEDefined := os.LookupEnv("XDG_DATA_DIRS") | ||
| if !isGPPEDefined || globalPluginPathsEnv == "" { |
There was a problem hiding this comment.
Suggested change
| globalPluginPathsEnv, isGPPEDefined := os.LookupEnv("XDG_DATA_DIRS") | |
| if !isGPPEDefined || globalPluginPathsEnv == "" { | |
| globalPluginPathsEnv, isGPPEDefined := os.LookupEnv("XDG_DATA_DIRS") | |
| if !isGPPEDefined || len(strings.TrimSpace(globalPluginPathsEnv)) == "" { |
just checking if its equal to "" wouldn't work since the envvar can be just a single space or some other whitespace
also what does GPPEDefined mean? I think something like XDDDefined would make more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core.LoadPlugin() function has been refactored to consider XDG_DATA_DIRS (from the FDO basedir spec) instead of having hardcoded paths. By doing so, there is no need to put "plugins.in" through sed anymore. Also, for this reason, the file has been renamed to "plugins.go" and has been removed from .gitignore and Makefile.