Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate plugins to c-shared #39

Merged
merged 1 commit into from
Apr 21, 2024
Merged

feat: Migrate plugins to c-shared #39

merged 1 commit into from
Apr 21, 2024

Conversation

axtloss
Copy link
Member

@axtloss axtloss commented Apr 21, 2024

This migrates plugins from using go/plugin to ebitengine/purego and c-shared. With this change vib and plugins do not need to be built against the exact same api version anymore, which makes the deployment of vib with plugins much easier.

TODO:

This pr is part of #34

This migrates plugins from using go/plugin to ebitengine/purego and c-shared.
With this change vib and plugins do not need to be built against the exact same api version anymore, which makes the deployment of vib with plugins much easier.
@axtloss axtloss marked this pull request as draft April 21, 2024 13:12
@axtloss axtloss marked this pull request as ready for review April 21, 2024 13:42
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (did not test)

@axtloss
Copy link
Member Author

axtloss commented Apr 21, 2024

A vib build with these commits added generates the identical (verified through sha256) Containerfile as the current vib release for both desktop-image and core-image. This can be considered stable.

@axtloss axtloss merged commit 90403e3 into main Apr 21, 2024
4 checks passed
@axtloss axtloss deleted the feat/c-shared-plugins branch April 21, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants