forked from Brunastephane/MLA-pilot
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added track distance changes #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchika512
assigned ruchika512, VathsalaAchar, HarshiSharma, Ahuja-Nisha and LakshmiAvanthiKaneti and unassigned VathsalaAchar and ruchika512
Mar 24, 2024
VathsalaAchar
unassigned VathsalaAchar, HarshiSharma, Ahuja-Nisha and LakshmiAvanthiKaneti
Mar 24, 2024
VathsalaAchar
requested review from
VathsalaAchar,
HarshiSharma,
Ahuja-Nisha and
LakshmiAvanthiKaneti
March 24, 2024 17:03
HarshiSharma
approved these changes
Mar 24, 2024
VathsalaAchar
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
HarshiSharma
pushed a commit
that referenced
this pull request
Mar 25, 2024
Modified below services Frontend service Added the new field on UI and passed the field to activity-tracking web service Validation to enter distance for running and swimming activities Css changes to add style for distance input field modified: frontend/src/App.css modified: frontend/src/components/trackExercise.js Activity-Tracking service Added the new field distance in the schema Added the new field in POST request & PUT request modified: activity-tracking/models/exercise.model.js modified: activity-tracking/routes/exercises.js
HarshiSharma
added a commit
that referenced
this pull request
Mar 25, 2024
* nav change manage ui change colour change and journal icon change * removing dummy data part oops * login and signup UI fix * added track distance changes (#21) Modified below services Frontend service Added the new field on UI and passed the field to activity-tracking web service Validation to enter distance for running and swimming activities Css changes to add style for distance input field modified: frontend/src/App.css modified: frontend/src/components/trackExercise.js Activity-Tracking service Added the new field distance in the schema Added the new field in POST request & PUT request modified: activity-tracking/models/exercise.model.js modified: activity-tracking/routes/exercises.js * login and signup UI fix * merge * bracket fix --------- Co-authored-by: ruchika512 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new field distance for "Track New Exercise" Page
Modified below services
Added the new field on UI and passed the field to activity-tracking web service
Validation to enter distance for running and swimming activities
Css changes to add style for distance input field
Added the new field distance in the schema
Added the new field in POST request & PUT request