Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an initial attempt at better error messages as discussed in the slack channel. I've implemented a custom BNError type we can use to designate various different forms of errors while keeping track of dependent Errors (causes) as well as the backtrace of each error.
This does unfortunately currently rely on the unstable backtrace feature:
#![feature(backtrace)]
For now, I only modified the code in
binaryview.rs
to use them, I'm happy to modify the rest after some review if this is something that will be incorporated :).