Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Add underscore to encodeURIComponent skipped characters #1105

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Vectorized
Copy link
Owner

Description

Not a big issue, as escaping underscores will still work tho.
Just not faithful to the JavaScript implementation.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

github-actions bot commented Oct 3, 2024

Gas Snapshot Comparison Report

Generated at commit : b3ba66e, Compared to commit : b43371a

Contract Name Test Name Main Gas PR Gas Diff
LibStringTest testStringEncodeURIComponent() 19245 20352 1107
testStringEscapeJSONHexEncode() 709115 710023 908
testStringPackAndUnpackOne() 737456 738627 1171
testStringPackAndUnpackTwo() 895109 1076843 181734
testToStringPositiveNumberBrutalized() 586828 587735 907
testToStringUint256MaxBrutalized() 598361 599237 876
testToStringZeroBrutalized() 586333 587208 875
test__codesize() 46318 46357 39

@Vectorized Vectorized merged commit 357d78e into main Oct 3, 2024
10 checks passed
@Vectorized Vectorized deleted the fix-encode-uri-component branch October 3, 2024 19:33
@atarpara
Copy link
Collaborator

atarpara commented Oct 4, 2024

@Vectorized LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants