Fix setup.sh

[g0tmi1k]

There was some bad practices going on. This fixes it some of it.

[g0tmi1k]

Please could there be a tag release after.
So then the Kali package can also be updated

[ChrisTruncer]

Thanks, setting up a clean VM to test this now. Always appreciate your help with this :)

There does seem to be one small but, getting this when running setup.sh

./setup/setup.sh: line 671: [: "9": integer expression expected

Will keep building out this VM to test this out

[ChrisTruncer]

Also, I don't think this installs pywintypes within wine. It's erroring out with that error for a python based payload. Will continue to test.

[g0tmi1k]

Cool. Will fix them up.
btw, is there a reason why it needs pyton2 & python3?
Could it be just one or the other:

v3 ~

Veil/setup/setup.sh

Line 362 in 1e87a3e

pip3 install pycrypto

v2 ~

Veil/setup/setup.sh

Line 321 in 1e87a3e

sudo pip2 install pefile

[g0tmi1k]

@ChrisTruncer Fixed line 671.

I've not noticed any issues with pywintypes.
Could you give any more information/details?

[ChrisTruncer]

It doesn't look to be installing the pywintypes library within python3 in Wine. To reproduce - use a clean VM, install Veil via sudo config/setup.sh -f -s. Once done installing, try generating any Veil python based payload (I'm using 33 the flat injection). When trying to "compile" with pyinstaller, it fails with the error shown below stating pywintypes library is not found.

[g0tmi1k]

Started to track down the issue... it only happens when you use setup.sh -s. (-f and not using anything is fine).

---

Update: Something because of pywin32-220.win32-py3.4.exe not like being silent installed.

Which has had an update since Veil-Evasion ~ https://github.com/Veil-Framework/Veil-Evasion/blob/master/setup/pywin32-219.win32-py2.7.exe.

So this isn't anything todo with the alteration which is in this PR, but another bug!

---

Solution: is to run a python script (Scripts/pywin32_postinstall.py) after its been extracted and moved to the correct folder

Final command: [ -e "SCRIPTS/pywin32_postinstall.py" ] && sudo -u "${trueuser}" WINEPREFIX="${winedir}" wine "${winedir}/drive_c/Python34/python.exe" "${winedrive}/Python34/Scripts/pywin32_postinstall.py" "-silent" "-quiet" "-install" >/dev/null

---

Proof

g0tmi1k@kali-dev:~/Desktop/Veil$ ./Veil.py --setup

 [!] ERROR: Missing /usr/share/veil/config/setup.sh

 ==========================================================================
                  Veil (Setup Script) | [Updated]: 2018-04-02
 ==========================================================================
  [Web]: https://www.veil-framework.com/ | [Twitter]: @VeilFramework
 ==========================================================================

 [I] Kali Linux "2018.1" x86_64 detected...

 [I] Silent Mode: Enabled
 [I]  Force Mode: Enabled
...SNIP...
g0tmi1k@kali-dev:~/Desktop/Veil$
g0tmi1k@kali-dev:~/Desktop/Veil$
g0tmi1k@kali-dev:~/Desktop/Veil$ ./Veil.py -t Evasion -p python/shellcode_inject/flat.py --ip 127.0.0.01 --port 4444
...SNIP...
8768 INFO: Building EXE from out00-EXE.toc completed successfully.

===============================================================================
                                   Veil-Evasion
===============================================================================
      [Web]: https://www.veil-framework.com/ | [Twitter]: @VeilFramework
===============================================================================

 [*] Language: python
 [*] Payload Module: python/shellcode_inject/flat
 [*] Executable written to: /opt/veil/output/compiled/payload2.exe
 [*] Source code written to: /opt/veil/output/source/payload2.py
 [*] Metasploit RC file written to: /opt/veil/output/handlers/payload2.rc
g0tmi1k@kali-dev:~/Desktop/Veil$

[ChrisTruncer]

Looks perfect now, merging in.

Thanks @g0tmi1k!

[g0tmi1k]

🎉
Thank you!