-
Notifications
You must be signed in to change notification settings - Fork 886
Conversation
Hey, I went through and tested this. Ran into one issue, and one oddity I wanted to run by you. With this current pull request, I can't generate golang based payloads. When trying to compile, it provides the following error: Also, this isn't a bug because it still works, but when giving the "generate" command, Veil normally used to go back to it's normal menu (it has the Veil header at the top) and asks how to get the shellcode. However, now it seems to just go to the next line down (in the pic below). I'm not sure if this is due to the patch, or somehow the code doing something odd. I'll try to check into it too. |
Sorry, the commits before were WIP. The reason why it continues, is because it was running
|
There looks to be a big when using msfvenom for generating shellcode rather than veil-ordnance. If you use msfvenom, you get asked for the payload type, IP, and port. It then asks if you have any extra options. If there are none, and you hit enter, msfvenom should generate the shellcode. However, if you hit enter, msfvenom isn't invoked, and you're dropped right into the Veil-Ordnance menu. |
As it already says "use" in the example, as well as it being the same in the other tool (as well as everything else!)
Thanks @leesoh ! |
@ChrisTruncer I can't find your bug. I don't know where you are looking/how you are trigging it. Evasion
Ordnance
|
No, it did not have the PR merged. I was using it as a separate baseline. I'm a little concerned that that change though is impacting Veil (as shown in the end of the pastebin). When I was trying to use Ordnance to generate shellcode, it couldn't take that generated shellcode back into Evasion. |
I'm fine with staying on the same menu and not going immediately back into the top level menu. But I'm not sure if that mod is preventing Evasion from grabbing the shellcode from Ordnance |
Could you give example commands/output, cos I'm really not seeing it. |
This is still staying in the Ordnance screen after generating shellcode (after it says "hit enter to return to veil-evasion"). Currently, you have to type back even though it says to hit enter. At this point, I'd prefer for it to jump right back into Evasion if using Ordnance as our shellcode generator. Sample output here - https://pastebin.com/xq3mY7um Also, line 158 and 159 show it not displaying the header and just has the commands right after the previous ones. |
sys.exit() | ||
|
||
|
||
sys.path.insert(0, settings.VEIL_EVASION_PATH + 'tools/ordnance') | ||
sys.path.insert(0, settings.VEIL_PATH + 'tools/ordnance') | ||
import tool as ordnance_import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
import tools as ordnance_import
rather than
import tool as ordnance_import
since the module(folder) name is tools
Same issue present in
tools/evasion/evasion_common/shellcode_help.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@programatologist ~ But the file it's including is called ./tools/ordnance/tool.py
not ./tools/ordnance/tools.py
?
sys.exit() | ||
|
||
|
||
sys.path.insert(0, settings.VEIL_EVASION_PATH + 'tools/ordnance') | ||
sys.path.insert(0, settings.VEIL_PATH + 'tools/ordnance') | ||
import tool as ordnance_import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
import tools as ordnance_import
rather than
import tool as ordnance_import
since the module(folder) name is tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@programatologist ~ But the file it's including is called ./tools/ordnance/tool.py
not ./tools/ordnance/tools.py
?
Working! The issue was we were using different payloads...
|
Ok, I figured out the reason @g0tmi1k if you are able to modify your pull request. This should be a quick fix. Line 741 should say "python3" instead of python when invoking the update-config.py script. After that, it seems to work and run on my system. Only final issue I am having is the tab completion and all of msfvenom shellcode generation is broken on Debian. Trying to look into it now. |
It looks like the "Metasploit_Path" variable is being set within the update-config.py file except for one-offs based on linux flavor detection and the path is being changed. Could you change line 178's default value of Metasploit_Path to be "/opt/metasploit-framework/embedded/framework/"? Veil needs it to be that path to properly parse available payloads under it. Once both changes (from above post too) are made, I think this is good to go. I'll test one more time, but seems to be working with these changes on my end. |
…hon & MSF path)
Rather than doing something like:
Something "better" would be to use the shebang to define the python version (as it is already set there!) ~ https://github.com/g0tmi1k/Veil/blob/4791e2a6b6c2b9e7a2759d9305965af0d4efa66e/config/update-config.py#L1. I dunno what the package path is for Metasploit outside of Kali :P. Commited! |
just pushed minor update to readme. All looks great! THanks for the large amount of time taken to do this, and it's now getting merged! |
merged! |
🎉 |
No description provided.