Revert "[VEN-1887]: Quantstamp audit fix for comptroller diamond proxy" #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolsvenus
added a commit
that referenced
this pull request
Sep 25, 2023
## [4.0.0-dev.1](v3.1.0...v4.0.0-dev.1) (2023-09-25) ### ⚠ BREAKING CHANGES * Removal of comptroller.sol ### Features * diamond proxy implementation of comptroller ([66f90f4](66f90f4)) * force liquidation implementation ([cf9c7cb](cf9c7cb)) * ven-1619 3.4 added view methods for facets states ([d12981f](d12981f)) ### Bug Fixes * comptroller diamond test for script ([a87f3e7](a87f3e7)) * diamond layout test ([3adf806](3adf806)) * docgen issue ([a46b205](a46b205)) * enter markets return empty array ([c57d257](c57d257)) * gas-01 ([e762a5d](e762a5d)) * gas-02 ([b3503c2](b3503c2)) * gas-06 ([0aea270](0aea270)) * lint ([a34816a](a34816a)) * lint ([d09d8d3](d09d8d3)) * lint errors. ([22e3887](22e3887)) * lint fix ([a41278c](a41278c)) * lint fix ([0f31c2a](0f31c2a)) * lint issues. ([b234a2f](b234a2f)) * merge branch 'develop' into feat/diamond-proxy ([e6e9ca5](e6e9ca5)) * minor issues. ([5601101](5601101)) * moved diamond's facets script ([a1d991f](a1d991f)) * no of optimizer runs ([c9417cf](c9417cf)) * pr comments ([0710b66](0710b66)) * pr comments ([35b5517](35b5517)) * pr comments ([68ef09b](68ef09b)) * pr comments, undo unwanted changes ([53a4dec](53a4dec)) * pr comments, used external instead of public ([5cdaa26](5cdaa26)) * removed unwanted checks from setTreasuryData ([6982bc5](6982bc5)) * replaced And operator with OR while checking cutoff ([fa26e52](fa26e52)) * resolve issues in script files ([2a634fb](2a634fb)) * resolve merge conflicts ([e3621e3](e3621e3)) * resolved conflicts ([1f1b0f9](1f1b0f9)) * resolved conflicts ([b4ddc09](b4ddc09)) * resolved conflicts, merged latest develop ([295609e](295609e)) * resolved merge conflicts with develop branch ([249eaee](249eaee)) * script for unitrollerAddress empty ([1f8263e](1f8263e)) * script owner rights and facet calls ([7b2eeeb](7b2eeeb)) * updated yarn.lock ([032cc8e](032cc8e)) * ven-1619 1.1 unnecessary immutable function ([9ef6b75](9ef6b75)) * ven-1619 2.1 added missing methods ([b5f701f](b5f701f)) * ven-1619 2.2, 2.3 moved MarketEntered event ([0225801](0225801)) * ven-1619 3.1 re-entrancy check in claimVenus ([8f5eeb5](8f5eeb5)) * ven-1619 3.3 shadowed variables in _setActionsPaused ([c256072](c256072)) * ven-1630 check for market not as collateral ([05ff797](05ff797)) * VEN-1686 ([94bc2e4](94bc2e4)) * ven-1699 n1 ([4598d00](4598d00)) * ven-1699 n2 ([13c0a92](13c0a92)) * ven-1699 pve001 ([f285dd1](f285dd1)) * ven-1699 pve002 ([b5ef58e](b5ef58e)) * ven-1757 vai-01 unnecesary remnant casting ([53a08eb](53a08eb)) * ven-1759 ddc-04 ([7417d8f](7417d8f)) * ven-1759 ddc-04 diamond loupe methods ([c797f14](c797f14)) * ven-1795 l-02 ([cfaa69a](cfaa69a)) * ven-1795 l-06 ([0aa7e17](0aa7e17)) * ven-1795 n-01 n-03 n-09 ([6d0a33c](6d0a33c)) * ven-1795 n-02 ([50761a0](50761a0)) * ven-1795 n-04 ([0387b34](0387b34)) * ven-1795 n-05 ([5533343](5533343)) * ven-1795 n-06 ([847afd7](847afd7)) * ven-1795 n-07 ([4596c2b](4596c2b)) * ven-1795 n-08 ([b0f39a1](b0f39a1)) * ven-1795 n-10 ([4c72e43](4c72e43)) * ven-1795 test for n-08 ([4c72287](4c72287)) * ven-1887 ven-04 ([c60497a](c60497a)) * ven-1887 ven-08 ([b745623](b745623)) ### Reverts * Revert "[VEN-1887]: Quantstamp audit fix for comptroller diamond proxy (#328)" (#337) ([9af2d4a](9af2d4a)), closes [#328](#328) [#337](#337) * ven-1795 changes for n-08 ([fd07edd](fd07edd))
toolsvenus
added a commit
that referenced
this pull request
Sep 25, 2023
## [4.0.0](v3.1.0...v4.0.0) (2023-09-25) ### ⚠ BREAKING CHANGES * Removal of comptroller.sol ### Features * diamond proxy implementation of comptroller ([66f90f4](66f90f4)) * force liquidation implementation ([cf9c7cb](cf9c7cb)) * ven-1619 3.4 added view methods for facets states ([d12981f](d12981f)) ### Bug Fixes * comptroller diamond test for script ([a87f3e7](a87f3e7)) * diamond layout test ([3adf806](3adf806)) * docgen issue ([a46b205](a46b205)) * enter markets return empty array ([c57d257](c57d257)) * gas-01 ([e762a5d](e762a5d)) * gas-02 ([b3503c2](b3503c2)) * gas-06 ([0aea270](0aea270)) * lint ([a34816a](a34816a)) * lint ([d09d8d3](d09d8d3)) * lint errors. ([22e3887](22e3887)) * lint fix ([a41278c](a41278c)) * lint fix ([0f31c2a](0f31c2a)) * lint issues. ([b234a2f](b234a2f)) * merge branch 'develop' into feat/diamond-proxy ([e6e9ca5](e6e9ca5)) * minor issues. ([5601101](5601101)) * moved diamond's facets script ([a1d991f](a1d991f)) * no of optimizer runs ([c9417cf](c9417cf)) * pr comments ([0710b66](0710b66)) * pr comments ([35b5517](35b5517)) * pr comments ([68ef09b](68ef09b)) * pr comments, undo unwanted changes ([53a4dec](53a4dec)) * pr comments, used external instead of public ([5cdaa26](5cdaa26)) * removed unwanted checks from setTreasuryData ([6982bc5](6982bc5)) * replaced And operator with OR while checking cutoff ([fa26e52](fa26e52)) * resolve issues in script files ([2a634fb](2a634fb)) * resolve merge conflicts ([e3621e3](e3621e3)) * resolved conflicts ([1f1b0f9](1f1b0f9)) * resolved conflicts ([b4ddc09](b4ddc09)) * resolved conflicts, merged latest develop ([295609e](295609e)) * resolved merge conflicts with develop branch ([249eaee](249eaee)) * script for unitrollerAddress empty ([1f8263e](1f8263e)) * script owner rights and facet calls ([7b2eeeb](7b2eeeb)) * updated yarn.lock ([032cc8e](032cc8e)) * ven-1619 1.1 unnecessary immutable function ([9ef6b75](9ef6b75)) * ven-1619 2.1 added missing methods ([b5f701f](b5f701f)) * ven-1619 2.2, 2.3 moved MarketEntered event ([0225801](0225801)) * ven-1619 3.1 re-entrancy check in claimVenus ([8f5eeb5](8f5eeb5)) * ven-1619 3.3 shadowed variables in _setActionsPaused ([c256072](c256072)) * ven-1630 check for market not as collateral ([05ff797](05ff797)) * VEN-1686 ([94bc2e4](94bc2e4)) * ven-1699 n1 ([4598d00](4598d00)) * ven-1699 n2 ([13c0a92](13c0a92)) * ven-1699 pve001 ([f285dd1](f285dd1)) * ven-1699 pve002 ([b5ef58e](b5ef58e)) * ven-1757 vai-01 unnecesary remnant casting ([53a08eb](53a08eb)) * ven-1759 ddc-04 ([7417d8f](7417d8f)) * ven-1759 ddc-04 diamond loupe methods ([c797f14](c797f14)) * ven-1795 l-02 ([cfaa69a](cfaa69a)) * ven-1795 l-06 ([0aa7e17](0aa7e17)) * ven-1795 n-01 n-03 n-09 ([6d0a33c](6d0a33c)) * ven-1795 n-02 ([50761a0](50761a0)) * ven-1795 n-04 ([0387b34](0387b34)) * ven-1795 n-05 ([5533343](5533343)) * ven-1795 n-06 ([847afd7](847afd7)) * ven-1795 n-07 ([4596c2b](4596c2b)) * ven-1795 n-08 ([b0f39a1](b0f39a1)) * ven-1795 n-10 ([4c72e43](4c72e43)) * ven-1795 test for n-08 ([4c72287](4c72287)) * ven-1887 ven-04 ([c60497a](c60497a)) * ven-1887 ven-08 ([b745623](b745623)) ### Reverts * Revert "[VEN-1887]: Quantstamp audit fix for comptroller diamond proxy (#328)" (#337) ([9af2d4a](9af2d4a)), closes [#328](#328) [#337](#337) * ven-1795 changes for n-08 ([fd07edd](fd07edd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #328