Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2032]: add contract with the consolidated interface of the Comptroller Diamond #364

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

chechu
Copy link
Member

@chechu chechu commented Oct 5, 2023

Description

Resolves VEN-2032

This way we'll be able to generate an ABI file, and the TS types, to interact with every functions and getters in the Comptroller contract

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@chechu chechu self-assigned this Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Code Coverage

Package Line Rate Branch Rate Health
Comptroller 100% 90%
Comptroller.Diamond 95% 59%
Comptroller.Diamond.facets 73% 62%
Comptroller.Diamond.interfaces 100% 100%
DelegateBorrowers 100% 86%
Governance 26% 25%
InterestRateModels 0% 0%
Lens 41% 37%
Liquidator 99% 89%
Oracle 100% 100%
PegStability 88% 84%
Swap 88% 57%
Swap.interfaces 100% 100%
Swap.lib 81% 53%
Tokens 100% 100%
Tokens.VAI 71% 46%
Tokens.VRT 20% 9%
Tokens.VTokens 35% 20%
Tokens.XVS 19% 8%
Utils 53% 35%
VRTVault 49% 36%
Vault 50% 45%
XVSVault 65% 52%
Summary 55% (2232 / 4054) 40% (924 / 2304)

Copy link
Contributor

@Debugger022 Debugger022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried to run all tests using the DiamondConsolidated contract and they are working fine

@chechu chechu marked this pull request as ready for review October 6, 2023 17:43
@chechu chechu requested a review from kkirka October 6, 2023 17:43
@chechu chechu merged commit 9ddf98b into develop Oct 9, 2023
3 checks passed
@chechu chechu mentioned this pull request Oct 18, 2023
4 tasks
@chechu chechu deleted the feat/VEN-2032 branch November 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants