-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use gmock btc 259 #27
Conversation
@@ -47,7 +47,8 @@ bool sanity_test_range_fmt() | |||
{ | |||
std::string test; | |||
try { | |||
test.at(1); | |||
char ignore = test.at(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like std::ignore could be used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes with < tuple > headers. Do not want to bring all tuple related stuff for such a small fix.
@@ -136,7 +136,8 @@ class SCOPED_LOCKABLE UniqueLock : public Base | |||
bool TryEnter(const char* pszName, const char* pszFile, int nLine) | |||
{ | |||
EnterCritical(pszName, pszFile, nLine, (void*)(Base::mutex()), true); | |||
Base::try_lock(); | |||
bool ignore = Base::try_lock(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like std::ignore could be used here
* Add ci, docker-compose, sonar * Add service locator, pop, rpc services (#1) Signed-off-by: Bogdan Vaneev <[email protected]> * Add RPC service implementation (#2) * Add rpc_service_impl Signed-off-by: Bogdan Vaneev <[email protected]> * Add opcodes Signed-off-by: Bogdan Vaneev <[email protected]> * Link libvbk everywhere Signed-off-by: Bogdan Vaneev <[email protected]> * Fix build Signed-off-by: Bogdan Vaneev <[email protected]> * Register RPCs Signed-off-by: Bogdan Vaneev <[email protected]> * Fix linker error * Make service locator templated * Use default template param to get rid of second overload of get/setService * Set timeout on build Signed-off-by: Bogdan Vaneev <[email protected]> * Fix usage on OP_CHECKATV&VTB Signed-off-by: Bogdan Vaneev <[email protected]> * Add test template Signed-off-by: Bogdan Vaneev <[email protected]> * Add fakeit Signed-off-by: Bogdan Vaneev <[email protected]> * Use fixture Signed-off-by: Bogdan Vaneev <[email protected]> * Move tests to vbk dir Signed-off-by: Bogdan Vaneev <[email protected]> * Fix double free Signed-off-by: Bogdan Vaneev <[email protected]> * Fix locator Signed-off-by: Bogdan Vaneev <[email protected]> * Disable -fno-devirtualize * Uncomment test Signed-off-by: Bogdan Vaneev <[email protected]> * Fix script_test Signed-off-by: Bogdan Vaneev <[email protected]> * Fix makefile Signed-off-by: Bogdan Vaneev <[email protected]> * Fix flag * Fix -fno-devirtualize flag * Add more interfaces (#3) * Add more interfaces Signed-off-by: Bogdan Vaneev <[email protected]> * Remove unneeded comments Signed-off-by: Bogdan Vaneev <[email protected]> * Fix build, sonar Signed-off-by: Bogdan Vaneev <[email protected]> * Add lcov coverage to sonar (#5) * Add lcov coverage to sonar Signed-off-by: Bogdan Vaneev <[email protected]> * Use gcovr Signed-off-by: Bogdan Vaneev <[email protected]> * Implement Util Service & add tests (#4) * Implement Util Service & add tests Signed-off-by: Bogdan Vaneev <[email protected]> * Add guard impl Signed-off-by: Bogdan Vaneev <[email protected]> * Remove slice; include vector Signed-off-by: Bogdan Vaneev <[email protected]> * Fix Signed-off-by: Bogdan Vaneev <[email protected]> * Add init methods (#7) * Fixe AreInputsStandard, GetTransactionSigOpCostGetP2SHSigOpCount (#6) * Fixe AreInputsStandard, GetTransactionSigOpCostGetP2SHSigOpCount * fixes * fixes * fixes * fixe test, udate UpdateCoins' (#9) * fixes (#12) * fixes * small fixe * fixe * Update src/vbk/util_service/util_service_impl.cpp Co-Authored-By: Bohdan <[email protected]> * Update src/script/interpreter.h Co-Authored-By: Bohdan <[email protected]> * fixes * bitcoin-cli: convert parameters of the RPC service from JSON as needed (#16) * update mempool, add grpc calls (#14) * update mempool, add grpc calls * remove grpc * fixe * Fix locator (#17) * Fix locator * Fixes * Use clang in CI * Generate genesis blocks; change merkle root calc (#13) * Generate genesis blocks; change merkle root calc * Fixes * Fix main genesis block; disable tests * Fix * Fix make check * tests: add a VeriBlock integration test runner (#10) * tests: add a VeriBlock integration test runner * add a linker flag to resolve circular dependencies * Fix CI * ExtractMatches: fix incorrect condition (#19) * ExtractMatches fixed * Fix BTC-31 * Add SavePopTxToDatabase (#20) * add forkresolution, calculate block without pop tx (#18) * add forkresolution, calculate block without pop tx * Feature/update mempool comparator (#21) * update comparator, add tests * Feature/validate poptx (#22) * Add validate pop tx * Add EvalScript for pOP * Remove unused config const * Fix typo * Fix tests * Feature/pop reward (#23) * add pop rewards * fixe tests * fixes * Feature/fix bitcoind dnsseed (#26) * fix bitcoind * remove seeds and checkpoint data * Feature/add grpc service (#24) * add interface for the statefull block validation * add first verson of grpc class * Add autogeneration * Change submodule git -> https * add grpc calls of the service * add statefull validation * Update proto to v1; fix in Makefile * Fix build * Fix build * fixe * Fix build * Fixes to please CI * Fix build * Fix * Fix * Fix * First version of config... will continue tomorrow * Fix * FIx * add Pop merkle root commitment (#27) * fixe bitcoind * Fix (#28) * Add CD (#30) * Add CD * Try * Try * Try * Fix prerelase on * Add submodules * Update strip code * Remove email * Revert stripping * change the getblocktemplate method (#31) * Feature/disable checks (#32) * Disable requirement on at least one node * Fix tests * Fixes of grpc (#33) * Fixes of grpc * Update docker-compose image * Remove prefix in cd * Fix * Update cd * Fix (#34)
* Introduce gmock * Add gtest to vcpkg * Fix pop_rewards test * Try with gmock * Add gmock libs to VBK integration tests * Cleanup Co-authored-by: blackyblack <[email protected]> Co-authored-by: Andrew Lekar <[email protected]>
* Introduce gmock * Add gtest to vcpkg * Fix pop_rewards test * Try with gmock * Add gmock libs to VBK integration tests * Cleanup Co-authored-by: blackyblack <[email protected]> Co-authored-by: Andrew Lekar <[email protected]>
No description provided.