Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonCropp committed Jun 3, 2021
1 parent 51ec58b commit 914db94
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 16 deletions.
6 changes: 3 additions & 3 deletions docs/diff-tool.custom.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var resolvedTool = DiffTools.AddTool(
exePath: diffToolPath,
binaryExtensions: new[] {"jpg"})!;
```
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L25-L35' title='Snippet source file'>snippet source</a> | <a href='#snippet-addtool' title='Start of snippet'>anchor</a></sup>
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L24-L34' title='Snippet source file'>snippet source</a> | <a href='#snippet-addtool' title='Start of snippet'>anchor</a></sup>
<!-- endSnippet -->

Add a tool based on existing resolved tool:
Expand All @@ -35,7 +35,7 @@ var resolvedTool = DiffTools.AddToolBasedOn(
name: "MyCustomDiffTool",
arguments: (temp, target) => $"\"custom args {temp}\" \"{target}\"");
```
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L64-L69' title='Snippet source file'>snippet source</a> | <a href='#snippet-addtoolbasedon' title='Start of snippet'>anchor</a></sup>
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L63-L68' title='Snippet source file'>snippet source</a> | <a href='#snippet-addtoolbasedon' title='Start of snippet'>anchor</a></sup>
<!-- endSnippet -->


Expand Down Expand Up @@ -63,7 +63,7 @@ var resolvedTool = DiffTools.AddToolBasedOn(

await DiffRunner.LaunchAsync(resolvedTool!, "PathToTempFile", "PathToTargetFile");
```
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L78-L85' title='Snippet source file'>snippet source</a> | <a href='#snippet-addtoolandlaunch' title='Start of snippet'>anchor</a></sup>
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L77-L84' title='Snippet source file'>snippet source</a> | <a href='#snippet-addtoolandlaunch' title='Start of snippet'>anchor</a></sup>
<!-- endSnippet -->


Expand Down
8 changes: 4 additions & 4 deletions docs/diff-tool.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Setting the `DiffEngine_MaxInstances` environment variable to the number of inst
```cs
DiffRunner.MaxInstancesToLaunch(10);
```
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L14-L18' title='Snippet source file'>snippet source</a> | <a href='#snippet-maxinstancestolaunch' title='Start of snippet'>anchor</a></sup>
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L13-L17' title='Snippet source file'>snippet source</a> | <a href='#snippet-maxinstancestolaunch' title='Start of snippet'>anchor</a></sup>
<!-- endSnippet -->


Expand Down Expand Up @@ -320,7 +320,7 @@ Non-MDI tools are prefered since it allows [DiffEngineTray](tray.md) to track an

#### Windows settings:

* Example arguments: ` -C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Example arguments: `-C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Scanned paths:

* `%ProgramFiles%\Perforce\p4merge.exe`
Expand All @@ -329,12 +329,12 @@ Non-MDI tools are prefered since it allows [DiffEngineTray](tray.md) to track an

#### OSX settings:

* Example arguments: ` -C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Example arguments: `-C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Scanned path: `/Applications/p4merge.app/Contents/MacOS/p4merge`

#### Linux settings:

* Example arguments: ` -C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Example arguments: `-C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Scanned path: `/usr/bin/p4merge`


Expand Down
2 changes: 1 addition & 1 deletion docs/diff-tool.order.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ For example `VisualStudio,Meld` will result in VisualStudio then Meld then all o
```cs
DiffTools.UseOrder(DiffTool.VisualStudio, DiffTool.AraxisMerge);
```
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L115-L117' title='Snippet source file'>snippet source</a> | <a href='#snippet-useorder' title='Start of snippet'>anchor</a></sup>
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L114-L116' title='Snippet source file'>snippet source</a> | <a href='#snippet-useorder' title='Start of snippet'>anchor</a></sup>
<!-- endSnippet -->
3 changes: 1 addition & 2 deletions src/DiffEngine.Tests/DiffToolsTest.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System.IO;
using System.Linq;
using System.Linq;
using System.Threading.Tasks;
using DiffEngine;
using Xunit;
Expand Down
6 changes: 3 additions & 3 deletions src/DiffEngine.Tests/diffTools.include.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ Non-MDI tools are prefered since it allows [DiffEngineTray](tray.md) to track an

#### Windows settings:

* Example arguments: ` -C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Example arguments: `-C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Scanned paths:

* `%ProgramFiles%\Perforce\p4merge.exe`
Expand All @@ -229,12 +229,12 @@ Non-MDI tools are prefered since it allows [DiffEngineTray](tray.md) to track an

#### OSX settings:

* Example arguments: ` -C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Example arguments: `-C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Scanned path: `/Applications/p4merge.app/Contents/MacOS/p4merge`

#### Linux settings:

* Example arguments: ` -C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Example arguments: `-C utf8-bom "targetFile" "tempFile" "targetFile" "targetFile"`
* Scanned path: `/usr/bin/p4merge`


Expand Down
2 changes: 1 addition & 1 deletion src/DiffEngine/Implementation/P4Merge.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ static partial class Implementation
public static Definition P4Merge()
{
static string Arguments(string temp, string target) =>
$" -C utf8-bom \"{target}\" \"{temp}\" \"{target}\" \"{target}\"";
$"-C utf8-bom \"{target}\" \"{temp}\" \"{target}\" \"{target}\"";

return new(
name: DiffTool.P4Merge,
Expand Down
1 change: 1 addition & 0 deletions src/DiffEngineTray.Tests/DiffEngineTray.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
<PackageReference Include="ProjectDefaults" Version="1.0.54" PrivateAssets="All" />
<PackageReference Include="XunitContext" Version="3.0.0" />
<ProjectReference Include="..\DiffEngineTray\DiffEngineTray.csproj" />
<ProjectReference Include="..\DiffEngine\DiffEngine.csproj" />
</ItemGroup>
</Project>

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
DiffEngine
DiffEngine

0 comments on commit 914db94

Please sign in to comment.