Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke diff in VisualStudio in the correct order #240

Closed
wants to merge 2 commits into from
Closed

invoke diff in VisualStudio in the correct order #240

wants to merge 2 commits into from

Conversation

MihailsKuzmins
Copy link

Issue: approvals/ApprovalTests.Net#549

  • changed order of tempFile and targetFile
  • .md files have been auto-adjusted

Now the position of the compared files is more intuitive, i.e.

  • new file (received): right-hand side
  • current file (approved): left-hand side
    image

@SimonCropp
Copy link
Member

so i checked the VS docs. and it seems the existing parameters are correct.

devenv /Diff SourceFile TargetFile

@MihailsKuzmins
Copy link
Author

well, yes, but the description does not unambiguously state which file is on the left-hand side and which one is on the right-hand side

SourceFile: Required. The full path and name of the first file to be compared.
TargetFile: Required. The full path and name of the second file to be compared.

What happens if you run DiffRunner.Launch(DiffTool.VisualStudio, "received.json", "approved.json") with the existing parameters?
For me the comparison output is ok only when I swapped the parameters in VisualStudio.cs. With the existing parameters I have the problem which I described in the original issue approvals/ApprovalTests.Net#549.

@SimonCropp
Copy link
Member

replaced by #243

@SimonCropp SimonCropp closed this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants