Implement environment variable as a possible path source for diff tools #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonCropp news on this? |
|
you seem to have only implemented for VisualStudioCode? |
yes, I'd like your feedback before having implemented for every single one of them |
|
Maybe there are some editors that can't be installed somewhere else than their default location for which this kind of option is not helpful, and given that I don't know if this is the case for the other editors I'm waiting your opinion |
|
i think operate under the assumption all apps can be installed in a custom location |
|
@dotnet-policy-service agree |
|
@SimonCropp done |
|
can you add some docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #310
Given that I don't know which versions and tools are "portable", that is, installable basically anywhere, I've just set up Visual Studio Code environment variable:
DiffEngine_VisualStudioCodefor windows.If you want more variables already set in this PR just tell me for which OS and diff tools -> var name.