fix gh-36: Add Duo support to ADFS #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Duo transaction is working but still getting an error when we bring the cookie back to ADFS.
This was referenced Jul 10, 2022
Closed
|
Hello @dboitnot This is failing the lint-test because |
|
Apologies, but my client who was using this has switched to AWS SSO so I don't have a way to test my changes anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #36 by adding Duo Support to the ADFS provider.
To get this to work in my environment also required the commits from #846 and #848. I've kept those commits separate from this PR but if you guys prefer, I can submit another PR with everything in one.