Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile changes for nvm and acknowledge CDK issue #25674 #24

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

bharber-vr
Copy link
Contributor

  • Adds .nvmrc file. This pins the node.js version to 18, which is the current LTS version and the version supported by the CDK at this time. When the .nvmrc file is present in the current working directory, nvm will use that version for the nvm install and nvm use commands. This allows us to specify the node version in one place and reduce friction during the setup process.
  • Modifies the Makefile commands to take advantage of nvm. nvm is already installed as a Homebrew dependency. The npx command allows us to use the CDK version installed in the node_modules directory of the blueprints app (vs relying on installing it globally and the versions potentially being out of sync)
  • Acknowledges ‼️ NOTICE: eks overly permissive trust policies aws/aws-cdk#25674 This can be fixed by upgrading the CDK, however this needs to be tested

…o automatically select the proper node version, Acknowledge CDK issue #25674
@bharber-vr bharber-vr merged commit 16f0731 into dev Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant