update cliListener.js #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite being inside a try/catch, data needs pre-validation of JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite being inside a try/catch, data needs pre-validation of JSON.
If one were to send
curl --http0.9 http://127.0.0.1:17117, the pool can crash withSyntaxError: Unexpected token 'G', "GET / HTTP"... is not valid JSONsince curl includes headers.Even sending
curl --http0.9 http://127.0.0.1:17117 -d '{"test": "test"}'can cause the thread to never send back a reply (causing curl to lock up).This isn't a patch to allow curl sends to be parsed; but, rather, a fix to protect the pool in any case where the server IP might be known and the port might be accessible or where the op may choose other CLI options.