Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid reporting NaN coverage #237

Merged
merged 3 commits into from
Mar 16, 2023
Merged

fix: avoid reporting NaN coverage #237

merged 3 commits into from
Mar 16, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Mar 16, 2023 •
edited
Loading

Description

When the total finds is 0 a division by 0 is performed throwing a NaN error.

# Before
NaN is less than min_coverage 100

# After
0 is less than min_coverage 100

Partially related to #146.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago changed the title fix: reporting NaN coverage fix: avoid reporting NaN coverage Mar 16, 2023
@alestiago alestiago marked this pull request as ready for review March 16, 2023 12:12
@alestiago alestiago self-assigned this Mar 16, 2023
@alestiago alestiago merged commit c50a398 into main Mar 16, 2023
@alestiago alestiago deleted the fix/NaN-coverage branch March 16, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alestiago @renancaraujo