Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: Add ability to retrieve payment terms using external id #106

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

warmwaffles
Copy link
Collaborator

  • Get a payment term using internal id or external id.
  • Update a payment term using internal id or external id.
  • Update a payment term's external id.
  • Delete a payment term using internal id or external id.
  • Create a payment with an external id. Upsert is not implemented, nor will it be.

Copy link
Contributor

@jonathanpglick jonathanpglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think UpdatePaymentTerm and PaymentTerm objects are both missing externalId.

vic.api.v0.yaml Outdated Show resolved Hide resolved
vic.api.v0.yaml Outdated Show resolved Hide resolved
vic.api.v0.yaml Outdated Show resolved Hide resolved
@warmwaffles warmwaffles merged commit d6c5dc4 into main Aug 26, 2024
1 check passed
@warmwaffles warmwaffles deleted the feat/add-external-id-to-payment-terms branch August 26, 2024 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants