New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pad r and s in signature to 32 bytes #4

Merged

frozeman merged 1 commit into VictorTaelin:master from carver:zero-pad-r-and-s

Jan 17, 2018

Contributor

carver commented Jan 15, 2018 •

edited

Loading

When decoded from an RLP transaction, r and s may be provided as less than 32 bytes.

This fixes the failing test in web3/web3.js#1290


          pad r and s in signature to 32 bytes

f0d7fc3

carver mentioned this pull request

Return r, s, and v without leading 0's web3/web3.js#1288

Merged

Collaborator

frozeman commented Jan 17, 2018

@MaiaVictor can we get this in?

frozeman merged commit 12b50d6 into VictorTaelin:master

carver deleted the zero-pad-r-and-s branch

January 17, 2018 20:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet