Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use more common templates #1454

Closed
wants to merge 2 commits into from
Closed

use more common templates #1454

wants to merge 2 commits into from

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Sep 5, 2024 •
edited
Loading

@github-actions github-actions bot added the k8s-stack k8s-stack helm chart related issue label Sep 5, 2024
@AndrewChubatiuk AndrewChubatiuk force-pushed the fail-chart-rendering-in-case-of-rule-name-colision branch from b35df2b to e87712c Compare September 5, 2024 11:36
@github-actions github-actions bot added agent vmagent helm chart related issue alert vmalert helm chart related issue auth vmauth helm chart related issue cluster vmcluster helm chart related issue operator operator helm chart related issue single VictoriaMetrics Single node helm chart related issue anomaly vmanomaly logs-single labels Sep 5, 2024
@AndrewChubatiuk AndrewChubatiuk changed the title fail chart rendering in case of rule name collision use more common templates Sep 5, 2024
@AndrewChubatiuk AndrewChubatiuk marked this pull request as draft September 5, 2024 20:15
@AndrewChubatiuk AndrewChubatiuk force-pushed the fail-chart-rendering-in-case-of-rule-name-colision branch 15 times, most recently from f38d6db to dc04aef Compare September 12, 2024 10:33
@AndrewChubatiuk AndrewChubatiuk changed the base branch from master to move-crds-to-separate-chart September 12, 2024 10:35
@AndrewChubatiuk AndrewChubatiuk force-pushed the move-crds-to-separate-chart branch 2 times, most recently from 179d10e to 623b529 Compare September 12, 2024 14:40
@AndrewChubatiuk AndrewChubatiuk force-pushed the fail-chart-rendering-in-case-of-rule-name-colision branch 2 times, most recently from 39f1363 to 6c3e7f5 Compare September 19, 2024 12:42
@AndrewChubatiuk AndrewChubatiuk changed the base branch from move-crds-to-separate-chart to master September 19, 2024 18:59
@AndrewChubatiuk AndrewChubatiuk force-pushed the fail-chart-rendering-in-case-of-rule-name-colision branch 4 times, most recently from f13fc7f to 305011f Compare September 20, 2024 06:06
@AndrewChubatiuk AndrewChubatiuk force-pushed the fail-chart-rendering-in-case-of-rule-name-colision branch 9 times, most recently from 4e24aee to 46aa65f Compare November 4, 2024 15:05
@AndrewChubatiuk AndrewChubatiuk marked this pull request as ready for review November 4, 2024 15:08
@AndrewChubatiuk AndrewChubatiuk force-pushed the fail-chart-rendering-in-case-of-rule-name-colision branch from 46aa65f to 602e145 Compare November 4, 2024 15:38
@AndrewChubatiuk AndrewChubatiuk deleted the fail-chart-rendering-in-case-of-rule-name-colision branch November 5, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

@f41gh7 f41gh7 Awaiting requested review from f41gh7 f41gh7 is a code owner

Assignees
No one assigned
Labels
agent vmagent helm chart related issue alert vmalert helm chart related issue anomaly vmanomaly auth vmauth helm chart related issue cluster vmcluster helm chart related issue k8s-stack k8s-stack helm chart related issue logs-single operator operator helm chart related issue single VictoriaMetrics Single node helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[victoria-metrics-k8s-stack] Use global.cluster.dnsDomain in all URL generation
1 participant
@AndrewChubatiuk