k8s-stack: check notifier.blackhole flag if no notifiers are set in vmalert
#1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
zekker6,
Haleygo and
f41gh7
as code owners
zekker6
reviewed
Sep 19, 2024
Comment on lines
259
to
261
| {{- if not (or (hasKey $spec "notifier") (hasKey $spec "notifiers") (hasKey $spec "notifierConfigRef")) }} | ||
| {{- fail "`notifier`, `notifiers` or `notifierConfigRef` should be set for vmalert"}} | ||
| {{- end }} |
There was a problem hiding this comment.
Wdyt about enforcing user to set notifier.blackhole if there are no other notifiers set?
This allows to make sure that user explicitly wants to blackhole all notifications and did not forget to set notifier by acccident.
AndrewChubatiuk
force-pushed
the
allow-no-notifiers
branch
from
8c77a00
to
9ba5d3f
Compare
AndrewChubatiuk
changed the title
notifier.blackhole if no notifiers are set
zekker6
previously approved these changes
Sep 19, 2024
zekker6
reviewed
Sep 19, 2024
| @@ -3,6 +3,7 @@ | |||
| - Added VMAuth to k8s stack. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/829) | |||
| - Fixed ETCD dashboard | |||
| - Use path prefix from args as a default path prefix for ingress. Related [issue](https://github.com/VictoriaMetrics/helm-charts/issues/1260) | |||
| - Force setting blackhole notifier if no notifiers are set | |||
There was a problem hiding this comment.
Suggested change
| - Force setting blackhole notifier if no notifiers are set | |
| - Allow using vmalert without notifiers configuration. Note that it is required to use `.vmalert.spec.extraArgs["notifiers.blackhole"]: true` in order to start vmalert with a blackhole configuration. |
AndrewChubatiuk
force-pushed
the
allow-no-notifiers
branch
from
9ba5d3f
to
fdac4c9
Compare
|
updated error in helm and changelog, please approve again |
Haleygo
approved these changes
Sep 20, 2024
Haleygo
changed the title
notifier.blackhole if no notifiers are setnotifier.blackhole flag if no notifiers are set in vmalert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://victoriametrics.slack.com/archives/CTC488T1P/p1726776490053099?thread_ts=1725540517.623349&cid=CTC488T1P