Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix misused securityContext and podSecurityContext #592

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix misused securityContext and podSecurityContext #592

merged 1 commit into from
Jul 25, 2023

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Jul 21, 2023

fix #455
securityContext should be used for containers, podSecurityContext should be used for pod

@Haleygo Haleygo requested review from Amper, zekker6 and f41gh7 July 21, 2023 15:01
@github-actions github-actions bot added alert vmalert helm chart related issue cluster vmcluster helm chart related issue single VictoriaMetrics Single node helm chart related issue logs-single labels Jul 21, 2023
f41gh7
f41gh7 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 7319ca5 into master Jul 25, 2023
@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 25, 2023

Thanks!

@f41gh7 f41gh7 deleted the fix-misused-securityContext branch July 25, 2023 08:22
zekker6 added a commit that referenced this pull request Jul 27, 2023
@zekker6
vlogs-single: fix podSecurityContext and securityContext usage
cbd08f6 
Follow-up for #592 to reflect swapped fields.
@zekker6 zekker6 mentioned this pull request Jul 27, 2023
Merged
zekker6 added a commit that referenced this pull request Jul 27, 2023
@zekker6
vlogs-single: fix podSecurityContext and securityContext usage (#597)
ce199d5 
Follow-up for #592 to reflect swapped fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@Amper Amper Awaiting requested review from Amper

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

@k1rk k1rk Awaiting requested review from k1rk

@tenmozes tenmozes Awaiting requested review from tenmozes

Assignees
No one assigned
Labels
alert vmalert helm chart related issue cluster vmcluster helm chart related issue logs-single single VictoriaMetrics Single node helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podSecurityContext and securityContext in values.yaml used interchangeably across helm charts
2 participants
@Haleygo @f41gh7