Skip to content

Commit

Permalink
fix: enable metrics flag for datasource list visibility (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
Loori-R authored Apr 5, 2024
1 parent aaf3ff8 commit 8f2f108
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## tip

* BUGFIX: change the `metrics` flag from `false` to `true` in `plugin.json` to ensure the plugin appears in the Grafana datasource selection list.

## v0.2.0

* FEATURE: add support for variables in the query. See [this issue](https://github.com/VictoriaMetrics/victorialogs-datasource/issues/5).
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The VictoriaLogs datasource plugin allows you to query and visualize

* [Installation](#installation)
* [How to make new release](#how-to-make-new-release)
* [Notes](#notes)
* [License](#license)

## Installation
Expand Down Expand Up @@ -282,6 +283,12 @@ This command will build frontend part and backend part or the plugin and locate
1. Go to <https://github.com/VictoriaMetrics/victorialogs-datasource/releases> and verify that draft release with the name `TAG` has been created and this release contains all the needed binaries and checksums.
1. Remove the `draft` checkbox for the `TAG` release and manually publish it.

## Notes

In the `plugin.json` file of our plugin, the `metrics` field is set to `true`. This is not to support metric queries in the classical sense but to ensure our plugin can be selected in the Grafana panel editor.

For more information on the fields in `plugin.json`, please refer to the [Grafana documentation](https://grafana.com/developers/plugin-tools/reference-plugin-json#properties).

## License

This project is licensed under
Expand Down
2 changes: 1 addition & 1 deletion src/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"id": "victorialogs-datasource",
"category": "logging",
"logs": true,
"metrics": false,
"metrics": true,
"alerting": false,
"annotations": true,
"streaming": false,
Expand Down

0 comments on commit 8f2f108

Please sign in to comment.