Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new WebKit API #1666

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Adopt new WebKit API #1666

merged 2 commits into from
Apr 27, 2023

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Apr 3, 2023

WKWebView isInspectable allows users to use Safari's developer mode to inspect Vienna's web views in release builds. Before this commit, only developer/debug builds were inspectable. _developerExtrasEnabled is not equivalent, it adds menu items to the context menu when invoked from one of Vienna's web views. I have left it there for ease of developing.

WKPreferences isElementFullscreenEnabled is equivalent to _fullScreenEnabled (in the WebKit source code, they invoke the same methods), despite the different name.

@Eitot Eitot linked an issue Apr 3, 2023 that may be closed by this pull request
@Eitot
Copy link
Contributor Author

Eitot commented Apr 6, 2023

GitHub Actions still does not support macOS 13. This means that Xcode 14.3 (which requires macOS 13) won't be supported until that happens.

barijaona
barijaona previously approved these changes Apr 7, 2023
@barijaona
Copy link
Member

GitHub Actions still does not support macOS 13.

They probably still have a bunch of 2014 MacMini's in their servers racks 😄

@josh64x2
Copy link
Member

josh64x2 commented Apr 8, 2023

GitHub Actions still does not support macOS 13. This means that Xcode 14.3 (which requires macOS 13) won't be supported until that happens.

It won't be too far off actions/runner-images#6426 (comment)

@barijaona
Copy link
Member

It's probably better to wait GitHub Actions' support of macOS 13 before merging this.

@Eitot
Copy link
Contributor Author

Eitot commented Apr 10, 2023

I don't mind. I was looking for a way to keep the project buildable with Xcode 14.2, but Swift has only limited support for compiler/preprocessor directives (MAC_OS_X_VERSION_MAX_ALLOWED would have been a way in Objective-C).

@Eitot Eitot marked this pull request as draft April 10, 2023 08:56
@barijaona
Copy link
Member

@Eitot Eitot marked this pull request as ready for review April 27, 2023 08:05
@barijaona barijaona merged commit 07ccc6a into ViennaRSS:master Apr 27, 2023
@Eitot Eitot deleted the feature/webkit-api branch April 27, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling the Safari WebInspector in WKWebViews
3 participants