-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt new WebKit API #1666
Adopt new WebKit API #1666
Conversation
GitHub Actions still does not support macOS 13. This means that Xcode 14.3 (which requires macOS 13) won't be supported until that happens. |
They probably still have a bunch of 2014 MacMini's in their servers racks 😄 |
It won't be too far off actions/runner-images#6426 (comment) |
It's probably better to wait GitHub Actions' support of macOS 13 before merging this. |
I don't mind. I was looking for a way to keep the project buildable with Xcode 14.2, but Swift has only limited support for compiler/preprocessor directives ( |
38abea0
to
33ac8bb
Compare
WKWebView
isInspectable
allows users to use Safari's developer mode to inspect Vienna's web views in release builds. Before this commit, only developer/debug builds were inspectable._developerExtrasEnabled
is not equivalent, it adds menu items to the context menu when invoked from one of Vienna's web views. I have left it there for ease of developing.WKPreferences
isElementFullscreenEnabled
is equivalent to_fullScreenEnabled
(in the WebKit source code, they invoke the same methods), despite the different name.