-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3SlotSetters linter/codemod draft #1669
Open
Spone
wants to merge
11
commits into
main
Choose a base branch
from
codemods/v3-slots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for de176b5 - Browse repository at this point
Copy the full SHA de176b5View commit details
Commits on Mar 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c413492 - Browse repository at this point
Copy the full SHA c413492View commit details
Commits on Apr 24, 2023
-
Update lib/view_component/codemods/v3_slot_setters.rb
Co-authored-by: Joel Hawksley <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 21a8a26 - Browse repository at this point
Copy the full SHA 21a8a26View commit details -
Update lib/view_component/codemods/v3_slot_setters.rb
Co-authored-by: Joel Hawksley <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb748a6 - Browse repository at this point
Copy the full SHA fb748a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d075cde - Browse repository at this point
Copy the full SHA d075cdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e376b29 - Browse repository at this point
Copy the full SHA e376b29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 547c202 - Browse repository at this point
Copy the full SHA 547c202View commit details
Commits on Apr 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2542ba5 - Browse repository at this point
Copy the full SHA 2542ba5View commit details
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b805fd7 - Browse repository at this point
Copy the full SHA b805fd7View commit details
Commits on Jun 29, 2023
-
Codemod v3 slots improvements (#1746)
* Add rake task for legacy slots detection * Add view component previews to codemod view paths * Autodetect rails view paths * Improve uncertain matches detection * Update lib/view_component/codemods/v3_slot_setters.rb Co-authored-by: Hans Lemuet <[email protected]> * Update usage instruction * Add rake task to migrate to new slots * Update changelog * Standardrb * Add tests * Call eager loading via Rails * Update docs/CHANGELOG.md Co-authored-by: Hans Lemuet <[email protected]> * Add support for passing view paths via CLI * Fix helper in rake tasks * Fix tests * Add note about codemod to changelog --------- Co-authored-by: Hans Lemuet <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3240607 - Browse repository at this point
Copy the full SHA 3240607View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf8a038 - Browse repository at this point
Copy the full SHA cf8a038View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.