Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot read property of null (reading 'getboundingclientrect') at ol-ext element.offsetrect #823

Closed
Bahaa-Fadhil opened this issue Jul 18, 2022 · 3 comments
Closed

cannot read property of null (reading 'getboundingclientrect') at ol-ext element.offsetrect #823

Bahaa-Fadhil opened this issue Jul 18, 2022 · 3 comments

Comments

@Bahaa-Fadhil
Copy link

Bahaa-Fadhil commented Jul 18, 2022 •
edited
Loading

Hi @Viglino

I have issue related to FixedPopup.

The error message I get at fixedPopup is, see error message below:

image

This is a bug when the map re-rendered on emptied, and it re due to the fact that there is a bug with fixed popup when the map is to be rendered or when the map is to switch between sound and dark theme when fixed popup is open.

Do you have any suggestion/ solution for this or way you can workaround this issue?
@Viglino
Copy link
Owner

Viglino commented Jul 24, 2022

Do you have an online example?

@Bahaa-Fadhil
Copy link
Author

No, but the error appears when a Fixed Popup tries to render in an empty map. It tries to set the popup position when the map is re-rendered.

Viglino added a commit that referenced this issue Jul 26, 2022
@Viglino
[UPD] #823
59c2dd7
@Viglino
Copy link
Owner

Viglino commented Jul 26, 2022

I've added a test to prevent rendering when the map in not displayed.

Siedlerchr added a commit to Siedlerchr/ol-ext that referenced this issue Aug 20, 2022
@Siedlerchr
Merge remote-tracking branch 'origin/master' into typejsdoc
75869ec 
* origin/master:
  [VER]
  [BUILD]
  [UPD] handle photos loading on legend items
  [BUILD]
  [UPD] collection
  [ADD] remove collection
  [BUILD]
  [BUG] clone FontSymbol
  [UPD] nominatim doc warning / Viglino#832
  [BUG] resetTransform on shadow
  [ADD] MGRS graticule example Viglino#825
  Add intervals and precision options
  [BUG] on tilematrix & legend
  [BUILD]
  [UPD] Viglino#823
  [UPD] draw panel on title change
  Update README.md
  Update README.md
  Update README.md

# Conflicts:
#	src/control/Graticule.js
#	src/control/LayerSwitcher.js
#	src/control/SearchNominatim.js
#	src/control/WMSCapabilities.js
#	src/control/WMTSCapabilities.js
#	src/legend/Legend.js
#	src/overlay/FixedPopup.js
#	src/style/FontSymbol.js
#	src/style/Photo.js
#	src/util/input/Collection.js
@Viglino Viglino closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Viglino @Bahaa-Fadhil