Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe : Each WebGL tile only clears its part of the canvas #1052

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Dolpic
Copy link

@Dolpic Dolpic commented Apr 18, 2024

During prerender, each WebGL tile only clears its side of the canvas. This enables having two WebGL layers in the same WebGL context (for example, swiping between two COG layers)

This solves the issue #1051

During prerender, each WebGL tile only clears its side of the canvas. This enables having two WebGL layers in the same WebGl context (for example, swiping between two COG layers)
@Viglino Viglino merged commit e98142a into Viglino:master Apr 18, 2024
@Viglino
Copy link
Owner

Viglino commented Apr 18, 2024

Nice workarround!
😞 but the issue still remains if you have 2 WebGL layers on the same side...
The context should be cleared only once...
But using classname solve it.

@Viglino
Copy link
Owner

Viglino commented Apr 18, 2024

Actually it doesn't work as you have to clean the other part of the screen when moving back the slider...

screen-capture.70.mp4

@Dolpic
Copy link
Author

Dolpic commented Apr 18, 2024

Oh yeah, nice catch, I didn't handle multiple layers on both sides.
I have this new PR that should handle this case : #1054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants