Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments just after opening brackets are not ignored #32

Closed
lesguillemets opened this issue Aug 24, 2014 · 3 comments
Closed

Comments just after opening brackets are not ignored #32

lesguillemets opened this issue Aug 24, 2014 · 3 comments

Comments

@lesguillemets
Copy link

Like this :

mydict = {
    "this" : "is good"
}

mydict = { # comments
          "this" : "does not seem good"
          }

This is troublesome when one wants to use foldmarker with (e.g.) dictionaries.

Sorry I couldn't come up with any PR.

@blueyed
Copy link
Member

blueyed commented May 6, 2015

Agreed.

The nothing_after_opening_paren would need to be improved to also ignore comments (https://github.com/hynek/vim-python-pep8-indent/blob/25a499c3a6c1c89f96e906a197cdc6939a8e309e/indent/python.vim#L148).

This could be refactored to use the same behaviour as for the "colon check" (improved in #41).

@blueyed
Copy link
Member

blueyed commented May 12, 2015

This should be fixed now.

Thanks for the report!

@blueyed blueyed closed this as completed May 12, 2015
@lesguillemets
Copy link
Author

👍 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants