Handle jedi-vim call signatures when looking for colon in prev line #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hynek |
|
Could you elaborate a bit more what this does? Does it use jedi for certain tasks if it’s present? |
|
jedi-vim provides call signatures, via inserting text into the buffer and then uses concealing to hide parts of it. I will refactor this to be used in more places, e.g. to also fix #32. |
| endif | ||
| let colon_pos = getpos(".")[2] | ||
| " Check that everything behind is to be ignored, including jedi-vim's | ||
| " call signatures). |
There was a problem hiding this comment.
here’s an extra paren. maybe you could add a sentence explaining what those are?
|
Re-based and squashed. |
I've tried to set it to true by default, but it is still buggy.
- Handle jedi-vim call signatures when looking for colon and function def in previous line. This adds `jedi\S` to s:skip_special_chars and improves the algorithm to find the colon in the previous line in `s:indent_like_previous_line`. - Add `s:match_expr_on_line` and use it for `nothing_after_opening_paren`. - Handle comments after opening paren (#32). NOTE: This handles older Vim versions, where `synconcealed` behaves different (returns an empty list for non-concealed) and `getcurpos` is not available (Vim 7.3.429 (used on Travis)). Fixes: #32
blueyed
added a commit
that referenced
this pull request
May 12, 2015
Handle jedi-vim call signatures when looking for colon in prev line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
jedi\Sto s:skip_special_chars and improves the algorithm tofind the colon in the previous line in
s:indent_like_previous_line.There should be a test for this probably?!
jedi-vim's syntax setup for the (partly concealed) call signature is at https://github.com/davidhalter/jedi-vim/blob/master/after/syntax/python.vim.