-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix None access exception #344
Open
tyru
wants to merge
2
commits into
Vimjas:master
Choose a base branch
from
tyru:fix-none-empty-entry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When empty entry in config like this: ``` policies: ``` vint always raises an exception. ``` AttributeError: 'NoneType' object has no attribute 'keys' ```
CI failed but I don't know how to fix this... |
blueyed
force-pushed
the
fix-none-empty-entry
branch
from
January 11, 2020 19:32
716515e
to
4fd6ada
Compare
Thanks, remove support for Python 3.4, and rebased it. |
blueyed
force-pushed
the
fix-none-empty-entry
branch
from
January 11, 2020 19:44
4fd6ada
to
f1ee41f
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
========================================
- Coverage 94.14% 94% -0.15%
========================================
Files 133 133
Lines 4152 4167 +15
Branches 417 418 +1
========================================
+ Hits 3909 3917 +8
- Misses 150 156 +6
- Partials 93 94 +1 |
tyru
force-pushed
the
fix-none-empty-entry
branch
from
January 12, 2020 09:27
f1ee41f
to
4ef550f
Compare
tyru
force-pushed
the
fix-none-empty-entry
branch
from
January 12, 2020 09:28
4ef550f
to
7758955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When empty entry in config like this:
vint always raises an exception.