Bugfix: Include related virtualAttributes in toJSON() calls #1258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When calling toJSON on a model with related objects, the related objects do not include their virtualAttributes.
Cause: Due to the change introduced in 5530377 (to close #1252), calls to
toJSON
set an array of virtualAttributes foropt.virtuals
. This array is then passed to child/related objecttoJSON
calls. This causes the related models to believe they were called withtoJSON({ virtuals: [<parent attributes>] })
, thus excluding their own virtualAttributes.For example, if a
Post
belongs to oneUser
, and theUser
has a virtualfullName
, callingpost.toJSON()
would not includeuser.fullName
I can confirm
v1.6.3
works as expected, andv1.6.4
introduced the bug.Solution:
This PR partially reverts 5530377 to allow for virtualAttributes to be calculated on a per-model basis by default.
Another solution would be to entirely revert 5530377