Fix typings for insert to accept model data interface #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaSemenov
changed the title
|
Is there any reason this shouldn't be merged? I don't see the point of having a PartialModelObject that has ModelObjects as fields. Or if you do then at least provide another type eg PartialModelRecursiveObject or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think #2190 has been given enough attention. Granted, the title was misleading, but it included a particular use case which was failing.
Even though objection.js documentation doesn't cover separation of model classes and model data interfaces, I don't believe this is an edge case which doesn't deserve any support.
This PR fixes the typings for plain
insert(notinsertGraph) to accept model data interfaces and adds the regression test.