Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit does not seem to be working correctly anymore in php 7+ #21

Merged
merged 7 commits into from
May 1, 2018

Conversation

NeoVance
Copy link

@NeoVance NeoVance commented Apr 2, 2018

This commit provides updated thruway/client as well as phpunit

Devon Bagley added 2 commits April 2, 2018 15:16
This commit provides updated thruway/client as well as phpunit
@Mulkave
Copy link
Member

Mulkave commented Apr 3, 2018

Thanks for the PR! This requires and update in travis.yml file as well in order to run the tests under php 7+ instead of 5+

@Mulkave
Copy link
Member

Mulkave commented Apr 3, 2018

Once this is done, will release a new version having all three changes together. Cheers!

@NeoVance
Copy link
Author

NeoVance commented Apr 9, 2018

Trying to figure out a way to split the tests, so that we can continue to test against at least 5.6 and 7.0+

Unfortunately every version of PHPUnit that supports 7.0+ requires 7.0+ dropping support for 5.x versions of PHP. Anyone have any thoughts on how to get around this? Most of my work with PHPUnit so far has targeted a single version of PHP, but I can see with Minion you might want to have some backwards compatibility.

@NeoVance
Copy link
Author

This is going to break testing on PHP versions pre 7.0.

It might be possible to support it by aliasing the class name, and having users install their own global phpunit rather than requiring a specific version.

@Mulkave Mulkave merged commit 0f9cf9b into Vinelab:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants