fix: refresh data on view loading

Vinzent03 · Sep 11, 2024 · 73d2c29 · 73d2c29
1 parent f4354e8
commit 73d2c29
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/commands.ts b/src/commands.ts
@@ -51,8 +51,6 @@ export function addCommmands(plugin: ObsidianGit) {
                 leaf = leafs.first()!;
             }
             app.workspace.revealLeaf(leaf);
-
-            dispatchEvent(new CustomEvent("git-refresh"));
         },
     });
     plugin.addCommand({
@@ -74,8 +72,6 @@ export function addCommmands(plugin: ObsidianGit) {
                 leaf = leafs.first()!;
             }
             app.workspace.revealLeaf(leaf);
-
-            dispatchEvent(new CustomEvent("git-refresh"));
         },
     });
 

diff --git a/src/ui/history/historyView.svelte b/src/ui/history/historyView.svelte
@@ -22,6 +22,7 @@
         }
     }
     addEventListener("git-view-refresh", refresh);
+    refresh();
     //This should go in the onMount callback, for some reason it doesn't fire though
     //setTimeout's callback will execute after the current event loop finishes.
     plugin.app.workspace.onLayoutReady(() => {
@@ -39,6 +40,10 @@
     }
 
     async function refresh() {
+        if (!plugin.gitReady) {
+            logs = undefined;
+            return;
+        }
         loading = true;
         const isSimpleGit = plugin.gitManager instanceof SimpleGit;
         logs = await plugin.gitManager.log(

diff --git a/src/ui/sourceControl/sourceControl.svelte b/src/ui/sourceControl/sourceControl.svelte
@@ -41,6 +41,7 @@
         }
     }
     addEventListener("git-view-refresh", refresh);
+    refresh();
     //This should go in the onMount callback, for some reason it doesn't fire though
     //setTimeout's callback will execute after the current event loop finishes.
     plugin.app.workspace.onLayoutReady(() => {