-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Graceful offline support #590
Comments
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 5, 2023
When disconnected from the internet and Obsidian git still attempts to pull changes it throws some panicky error messages. Check the connectivity to githubstatus before attempting to pull/push changes
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 5, 2023
When disconnected from the internet and Obsidian git still attempts to pull changes it throws some panicky error messages. Check the connectivity to githubstatus before attempting to pull/push changes
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 5, 2023
When disconnected from the internet and Obsidian git still attempts to pull changes it throws some panicky error messages. Check the connectivity to githubstatus before attempting to pull/push changes
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 7, 2023
When disconnected from the internet and Obsidian git still attempts to pull changes it throws some panicky error messages. Check the connectivity before attempting to pull/push changes
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 7, 2023
Set plugin to offline mode when there is no network connection. Pull changes when network state changes and plugin was in offline mode
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 11, 2023
Check app online connectivity before attempting to pull/push changes
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Sep 11, 2023
+ Set offline mode when there is no network connection and an remote attempt is made. + Reset offline mode flag when connectivity re-establishes and pull changes (delayed pull/push request)
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Jan 26, 2024
Check app online connectivity before attempting to pull/push changes
bardbess
pushed a commit
to bardbess/obsidian-git
that referenced
this issue
Jan 26, 2024
+ Set offline mode when there is no network connection and an remote attempt is made. + Reset offline mode flag when connectivity re-establishes and pull changes (delayed pull/push request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Fristly, thanks for this great plugin!
When disconnected from the internet and Obsidian git still attempts to pull changes it throws some panicky error messages.
I'm wondering if this could be wrapped up into a simple 'No Github.com Connection' message.
Relevant errors (if available) from notifications or console (
CTRL+SHIFT+I
)Steps to reproduce
Disconnect from the internet
Start Obsidian
Expected Behavior
A simple user friendly error message, eg:
Addition context
No response
Operating system
Android
Installation Method
None
Plugin version
2.20.7
The text was updated successfully, but these errors were encountered: