Ensure directories are created recursively when calling package (#1371

)
VirtusLab · Sep 19, 2022 · 54aefdd · 54aefdd
1 parent 880242e
commit 54aefdd
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/modules/cli/src/main/scala/scala/cli/commands/Package.scala b/modules/cli/src/main/scala/scala/cli/commands/Package.scala
@@ -304,20 +304,20 @@ object Package extends ScalaCommand[PackageOptions] with BuildCommandHelpers {
           val content = Library.libraryJar(build)
           alreadyExistsCheck()
           if (force) os.write.over(destPath, content)
-          else os.write(destPath, content)
+          else os.write(destPath, content, createFolders = true)
           destPath
         case PackageType.SourceJar =>
           val now     = System.currentTimeMillis()
           val content = sourceJar(build, now)
           alreadyExistsCheck()
-          if (force) os.write.over(destPath, content)
-          else os.write(destPath, content)
+          if (force) os.write.over(destPath, content, createFolders = true)
+          else os.write(destPath, content, createFolders = true)
           destPath
         case PackageType.DocJar =>
           val docJarPath = value(docJar(build, logger, extraArgs))
           alreadyExistsCheck()
-          if (force) os.copy.over(docJarPath, destPath)
-          else os.copy(docJarPath, destPath)
+          if (force) os.copy.over(docJarPath, destPath, createFolders = true)
+          else os.copy(docJarPath, destPath, createFolders = true)
           destPath
         case a: PackageType.Assembly =>
           value {

diff --git a/modules/cli/src/main/scala/scala/cli/internal/ProcUtil.scala b/modules/cli/src/main/scala/scala/cli/internal/ProcUtil.scala
@@ -29,7 +29,7 @@ object ProcUtil {
             content.drop("#!/bin/sh".length)
         else
           sys.error("Can't happen")
-      os.write.over(file, updatedContent)
+      os.write.over(file, updatedContent, createFolders = true)
     }
 
     usesSh

diff --git a/modules/integration/src/test/scala/scala/cli/integration/PackageTestDefinitions.scala b/modules/integration/src/test/scala/scala/cli/integration/PackageTestDefinitions.scala
@@ -812,6 +812,24 @@ abstract class PackageTestDefinitions(val scalaVersionOpt: Option[String])
     }
   }
 
+  test("ensure directories are created recursively when packaging a jar") {
+    TestInputs(
+      os.rel / "Simple.scala" -> s"""object Simple extends App { println() }"""
+    ).fromRoot { (root: os.Path) =>
+      val jarPath =
+        os.rel / "out" / "inner-out" / "Simple.jar" // the `out` directory doesn't exist and should be created
+      os.proc(
+        TestUtil.cli,
+        "package",
+        ".",
+        "--library",
+        "-o",
+        jarPath,
+        extraOptions
+      ).call(cwd = root)
+    }
+  }
+
   def javaOptionsDockerTest(): Unit = {
     val fileName           = "Hello.scala"
     val imageName          = "hello"