Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse publishing artifact definition in the Maven export #3083

Open
yadavan88 opened this issue Aug 8, 2024 · 1 comment
Open

Reuse publishing artifact definition in the Maven export #3083

yadavan88 opened this issue Aug 8, 2024 · 1 comment
Labels
export issues tied to the export sub-command missing feature Something should have been implemented, but wasn't. mvn Issues tied to Maven export/integrations. publish command

Comments

@yadavan88
Copy link
Contributor

We need to check and fix the issue with publish directive in maven export. It should pass the artifactId, groupId and version number correctly based on the publish directive

@yadavan88 yadavan88 added the bug Something isn't working label Aug 8, 2024
@Gedochao Gedochao changed the title Maven - Fix publish issue Reuse publishing artifact definition in the Maven export Aug 9, 2024
@Gedochao Gedochao added publish command export issues tied to the export sub-command mvn Issues tied to Maven export/integrations. labels Aug 9, 2024
@Gedochao
Copy link
Contributor

Gedochao commented Aug 9, 2024

As for the requirements.
We have a bunch of directives used for the publish command, which allow to define the artifact name, groupId and version.
Those already have directives, but currently aren't used in the --maven export (or --sbt/--mill, for that matter).
It'd make sense to reuse them.

Namely, those are:

//> using publish.organization <org>
//> using publish.name <name>
//> using publish.version <version>

@Gedochao Gedochao added missing feature Something should have been implemented, but wasn't. and removed bug Something isn't working labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export issues tied to the export sub-command missing feature Something should have been implemented, but wasn't. mvn Issues tied to Maven export/integrations. publish command
Projects
None yet
Development

No branches or pull requests

2 participants